REGR: concat materializing index even if sort is not necessary #47508
Conversation
phofl
added
Regression
| @@ -157,7 +157,7 @@ def _get_combined_index( | |||
| index = union_indexes(indexes, sort=False) | |||
| index = ensure_index(index) | |||
|
|
|||
| if sort: | |||
| if sort and not index.is_monotonic_increasing: | |||
There was a problem hiding this comment.
maybe better to just have safe_sort check this internally? (we do this in sort_values for example)
There was a problem hiding this comment.
Index.is_monotonic_decreasing as well?
Also I think a separate PR will need to be made against 1.4.x. safe_sort_index below is available on main and not 1.4.x
There was a problem hiding this comment.
Yeah sorry, should have mentioned this. I’ll clean this up after this is backported
There was a problem hiding this comment.
So to confirm, once this is merged into main and backported, you'll modify the backport branch to be compatable with the 1.4.x branch?
There was a problem hiding this comment.
No this should be compatible with 1.4.x if I am not missing anything.
I will create a new pr after this is merged and will move the no op check to safe_sort_index
There was a problem hiding this comment.
Okay gotcha. So does is_monotonic_decreasing also need to be added too?
There was a problem hiding this comment.
I don’t think so, if you want to sort and it is decreasing, you would have to turn the Range index around basically. We could add some logic for this, but not for 1.4.x I think
|
this version prob ok for 1.4 can do enhanced for 1.5 |
|
Thanks @phofl |
This comment was marked as resolved.
This comment was marked as resolved.
|
Could you manual backport when you get the chance @phofl? |
|
Yep, will do tomorrow |
…s-dev#47508) * REGR: concat materializing index even if sort is not necessary * Add check for index * Add exact
|
The conflict was caused by tests :) |
…even if sort is not necessary )" (#47565)
…s-dev#47508) * REGR: concat materializing index even if sort is not necessary * Add check for index * Add exact
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.